Request for reviews (S): 7085137: -XX:+VerifyOops is broken

Vladimir Kozlov vladimir.kozlov at ORACLE.COM
Tue Aug 30 18:14:15 PDT 2011


Thank you, Tom

Vladimir

Tom Rodriguez wrote:
> Looks good.
> 
> tom
> 
> On Aug 30, 2011, at 2:26 PM, Vladimir Kozlov wrote:
> 
>> http://cr.openjdk.java.net/~kvn/7085137/webrev
>>
>> 7085137: -XX:+VerifyOops is broken
>>
>> I hit my new assert about different code emit size (7063629) when I specified -XX:+VerifyOops on sparc.  It uses set((intptr_t)msg, O0) instruction to set address of message which is new each time, as result set() size could be different.
>> Replace set() with patchable_set() to generate 8 instructions always.
>> Add missing case Op_PrefetchAllocation in verification code in emit_form3_mem_reg().
>>
>> Thanks,
>> Vladimir
> 


More information about the hotspot-compiler-dev mailing list