Request for review: 7117052 instanceKlass::_init_state can be u1 type
Jiangli Zhou
jiangli.zhou at oracle.com
Fri Dec 2 10:55:01 PST 2011
Hi David,
Thanks for catching that. I changed the debug version of
set_init_state(). The updated webrev is
http://cr.openjdk.java.net/~jiangli/7117052/webrev.01/.
Thanks,
Jiangli
On 12/01/2011 05:18 PM, David Holmes wrote:
> As already mentioned in internal email, there seem to be changes
> missing for debug builds. In instanceKlass set_init_state has two
> implementations - one for product and one for debug. The debug version
> has not been modified to accommodate the change in type.
>
> David
>
> On 2/12/2011 4:51 AM, Jiangli Zhou wrote:
>> The instanceKlass::_init_state is defined as instanceKlass::ClassState
>> type, which is an enum. Currently there are 7 class states defined. The
>> instanceKlass::_init_state can be changed to u1 type, which could hold
>> up 256 states. There are unused bytes after
>> instanceKlass::_idnum_allocated_count field. Changing _init_state to u1
>> and move it to after the _idnum_allocate_count field would save 4-byte
>> for each loaded class.
>>
>> http://cr.openjdk.java.net/~jiangli/7117052/webrev.00/
>>
>> Thanks,
>>
>> Jiangli
>>
More information about the hotspot-compiler-dev
mailing list