Request for reviews (S): 7110832: ctw/.../org_apache_avalon_composition_util_StringHelper crashes the VM

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Dec 22 16:34:46 PST 2011


Thanks Igor

Igor Veresov wrote:
> Looks good! 
> 
> But I don't think you need this statement:
> 265 friend class ShortBranchVerifier;
> 

Yes, it works without it.

Vladimir

> 
> 
> igor
> 
> 
> On Thursday, December 22, 2011 at 4:12 PM, Vladimir Kozlov wrote:
> 
>> http://cr.openjdk.java.net/~kvn/7110832/webrev
>>
>> 7110832: ctw/.../org_apache_avalon_composition_util_StringHelper crashes the VM
>>
>> Distance is too large for one short branch in string_indexofC8(). Note, it does 
>> not fail always because different REX prefixes are generated for different input 
>> registers.
>>
>> I added verification code in debug VM by reducing allowed distance (by 32 bytes) 
>> for short branches. It can be used in a large hand written assembler code.
>>
>> Tested with full CTW.
>>
>> Thanks,
>> Vladimir
> 
> 
> 


More information about the hotspot-compiler-dev mailing list