review (XS) for 7018506: CTW swallowing OOMs after symbol changes

Igor Veresov igor.veresov at oracle.com
Thu Feb 10 12:21:03 PST 2011


Looks ok.

igor

On 2/10/11 11:47 AM, Tom Rodriguez wrote:
> Coleen pointed out there are other unchecked CLEAR_PENDING_EXCEPTION calls so I've modified it to check at all of them.  Please re-review.
>
> tom
>
> On Feb 10, 2011, at 11:36 AM, Igor Veresov wrote:
>
>> Looks good.
>>
>> igor
>>
>> On 2/10/11 11:13 AM, Tom Rodriguez wrote:
>>> http://cr.openjdk.java.net/~never/7018506
>>>
>>> 7018506: CTW swallowing OOMs after symbol changes
>>> Reviewed-by:
>>>
>>> Previously the symbol creation could throw an OOM for perm but now it
>>> can't and the next two exception points just swallowed exception so it
>>> keeps on going.  The fix is to always allow OOMs to be propagated.
>>> Tested with CTW.
>>
>



More information about the hotspot-compiler-dev mailing list