review (S) for 7021603: crash in fill_sync_handler with ExtendedDTrace probes

Igor Veresov igor.veresov at oracle.com
Tue Feb 22 18:32:05 PST 2011


Looks good!

igor

On 2/22/11 6:14 PM, Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/7021603
>
> 7021603: crash in fill_sync_handler with ExtendedDTrace probes
> Reviewed-by:
>
> The changes for 6809483 added some callouts to notify dtrace for
> inlined methods.  In fill_sync_handler it's using the regular append
> call which expects there to be a ciBytecodeStream to get the current
> bci from but in the fill_sync_handler there is no stream so it
> crashes.  The code should be use append_with_bci like the other
> existing code there.  Tested with failing tests.



More information about the hotspot-compiler-dev mailing list