The fix for 6989984 broke the build of hsdis

Tom Rodriguez tom.rodriguez at oracle.com
Mon Feb 28 16:44:44 PST 2011


http://cr.openjdk.java.net/~never/7023229

7023229: extraneous include of precompiled.hpp in hsdis.c
Reviewed-by: never
Contributed-by: volker.simonis at gmail.com

The fix for 6989984 added an include of precompiled.hpp to hsdis.c
which it shouldn't have.  The fix to simply remove it.  hsdis-demo.c
had the same problem.  I checked the other files in src/share/tools
for mention of precompiled.hpp and those were the only ones I found.
Tested by building hsdis and hsdis-demo.

On Feb 28, 2011, at 7:48 AM, Volker Simonis wrote:

> The change "6989984: Use standard include model for Hospot" broke the
> hsdisbuild under src/share/tools/hsdis.
> 
> The fix ix easy, just remove the dependency on "precompiled.hpp" from hsdis.c:
> 
> 
> diff -r 79fe787a0420 src/share/tools/hsdis/hsdis.c
> --- a/src/share/tools/hsdis/hsdis.c     Fri Feb 25 16:40:03 2011 +0100
> +++ b/src/share/tools/hsdis/hsdis.c     Mon Feb 28 16:17:00 2011 +0100
> @@ -22,8 +22,6 @@
>  *
>  */
> 
> -#include "precompiled.hpp"
> -
> /* hsdis.c -- dump a range of addresses as native instructions
>    This implements the plugin protocol required by the
>    HotSpot PrintAssembly option.



More information about the hotspot-compiler-dev mailing list