Request for reviews (S): 7010180: JSR 292 InvokeDynamicPrintArgs fails with: assert(_adapter == NULL) failed: init'd to NULL

[Christian Thalinger]

On Jan 4, 2011, at 6:06 PM, Tom Rodriguez wrote:
> 
> On Jan 4, 2011, at 8:54 AM, Christian Thalinger wrote:
> 
>> http://cr.openjdk.java.net/~twisti/7010180/webrev.01/
>> 
>> 7010180: JSR 292 InvokeDynamicPrintArgs fails with: assert(_adapter == NULL) failed: init'd to NULL
>> Reviewed-by:
>> 
>> Since 7007377 during method handles adapter generation the adapters
>> for sun.dyn.MethodHandleImpl::raiseException are also generated.
>> Later when the Rewriter wants to link the method the adapter entry
>> already exists and the assert triggers.
>> 
>> The fix is to link sun.dyn.MethodHandleImpl class before generating
>> the method handle adapters.  This ensures that the required
>> c2i-adapter exists.
> 
> That looks good.

Thank you, Tom.  -- Christian