Request for reviews (XS): 7010913: JSR 292 ciMethodHandle does not handle MethodHandleCompiler exceptions properly

Tom Rodriguez tom.rodriguez at oracle.com
Fri Jan 7 11:34:11 PST 2011


Looks good.

tom

On Jan 7, 2011, at 3:17 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/7010913/webrev.01/
> 
> 7010913: JSR 292 ciMethodHandle does not handle MethodHandleCompiler exceptions properly
> Reviewed-by:
> 
> This is a spin-off from 7009600 to fix the fact that
> ciMethodHandle::get_adapter does not handle MethodHandleCompiler
> exceptions properly.  7009600 should fix the actual conversion
> problem.
> 
> ciMethodHandles::get_adapter should use CATCH instead of CHECK_NULL
> which returns a null-pointer as target method.



More information about the hotspot-compiler-dev mailing list