Request for review(XS): 7012766: assert(false) failed: DEBUG MESSAGE in MacroAssembler::debug32

[Tom Rodriguez]

There are four calls to profile_method in x86 code but I only see two fixed.  Don't the other need fixed?  Actually set_method_data_pointer_for_bc seems strangely coded to me.  

void InterpreterMacroAssembler::set_method_data_pointer_for_bcp() {
  assert(ProfileInterpreter, "must be profiling interpreter");
  Label set_mdp;
  push(rax);
  push(rbx);

  get_method(rbx);

Why couldn't it either assume it was valid or correctly set it up?

tom

On Jan 18, 2011, at 3:45 PM, Igor Veresov wrote:

> Interpreter expects to see methodOop in rbx on method entry, which needs to be restored after call to profile_method.
> 
> Webrev: http://cr.openjdk.java.net/~iveresov/7012766/webrev.00
> 
> Tested: failing nightly
> 
> Thanks,
> igor