review request (L): 7012650: implement JSR 292 EG adjustments through January 2010

[Rémi Forax]

On 01/20/2011 10:23 PM, John Rose wrote:
> The webrev is refreshed; there are now changes to ClassValue.java.
>
> http://cr.openjdk.java.net/~jrose/7012650/webrev.00/src/share/classes/java/dyn/ClassValue.java.udiff.html
>
> -- John

Hi John,
I suppose that classValueFrom() shoud be static.
The implementation of FromMethodhandle.computeValue() creates a hole in 
the typesystem.
You mix parameterized type (T) and MethodHandle that aren't typed by the 
compiler.

return (T) result;  // this cast is unsafe and not enforced anywhere

I wonder if it's not better to wait the introduction of lambda here.

Rémi

> On Jan 20, 2011, at 11:59 AM, John Rose wrote:
>
>> These are the rest of the EG-requested changes for JSR 292:
>>   http://cr.openjdk.java.net/~jrose/7012650/webrev.00/
>>
>> After these changes, plus some renames, we will be ready for formal Public Review.
>>
>> (The two deprecated methods were going to be removed, but we ran into some minor technical problems, which we are working on.)
>>
>> -- John