Request for review(XS): 7013812: C1: deopt blob too far from patching stub

Tom Rodriguez tom.rodriguez at oracle.com
Thu Jan 20 22:40:21 PST 2011


>> This is similar to what is done in generate_handle_exception for similar reasons.
> 
> Thanks, Tom, webrev updated.
> One, question. Will we ever have to do the relocation for this jump sequence? It will be currently matched as a far call by the relocation logic, for which we don't do anything.

For jumps we don't have to do anything since they are absolute addresses.  We still put reloc on them for consistency.

tom

> 
> Another fix though, can be just to always generate true br, which should give enough range.
> 
> igor
> 
>> 
>> tom
>> 
>>> 
>>> igor
>>> 
>>> On 1/20/11 9:28 PM, Igor Veresov wrote:
>>>> access_filed_patching and load_klass_patching stubs are using
>>>> effectively a bp instruction to jump to deopt blob. This limits the
>>>> distance between the deopt blob and these stub to 2^20, which is not
>>>> enough. Since this situation could become possible also with a 32bit VM
>>>> (the distance is only 1M), I decided to always use long jumps.
>>>> 
>>>> Webrev: http://cr.openjdk.java.net/~iveresov/7013812/webrev.00/
>>>> 
>>>> Thanks,
>>>> igor
>>>> 
>>> 
>>> 
>> 
> 



More information about the hotspot-compiler-dev mailing list