review for 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods

[Dmitry Samersoff]

Tom,

methodHandles_x86.cpp:

Do we need const and assignment here?

1185       const Register rax_pc = rax;
1186       __ pop(rax_pc);  // caller PC


Otherwise looks good for me.

-Dmitry

On 2011-07-09 00:10, Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6990212
> 154 lines changed: 117 ins; 19 del; 18 mod; 5215 unchg
>
> 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods
> Summary: check for single stepping when dispatching invokes from method handles
> Reviewed-by:
>
> Single stepping and method entry events requires some machinery in the
> interpreter to make sure that we never jump into compiled code but the
> method handle invoke path doesn't have that code.  The fix is to
> reintroduce the required check and dispatch to the interpreted entry
> in that case.  Tested with failing test cases from report plus a
> simple test case to exercise the MH raiseException path since I had to
> rewrite the arugment passing there.
>


-- 
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...