review for 7012081: JSR 292: SA-JDI can't read MH/MT/Indy ConstantPool entries

[John Rose]

On Jul 11, 2011, at 10:50 AM, Tom Rodriguez wrote:

>> Is the debugging code in isValid intentional?
> 
> No.  Thanks for catching that.  I've fixed it.

In that function there is a new line; is it really needed?
                || ctag.isMethodHandle() || ctag.isMethodType()
+               || ctag.isMethod()
                || ctag.isInt() || ctag.isFloat())? true: false;

The rest of it looks fine.

Some of the new Java code it resembles the corresponding C++ code, in that it seems like code that should be distrusted until it is fully exercised by tests.

-- John


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20110712/aef8a9b6/attachment.html