review for 7012081: JSR 292: SA-JDI can't read MH/MT/Indy ConstantPool entries

[Tom Rodriguez]

On Jul 12, 2011, at 7:01 PM, John Rose wrote:

> On Jul 12, 2011, at 6:05 PM, Tom Rodriguez wrote:
> 
>> 
>> Yes that was required for it to pass.  Is that unexpected?  This code has no parallel in the C++ code.
> 
> Yes, I'm surprised that somebody is making a reference to a CONSTANT_Methodref from something related to ldc or a bootstrap method specifier (or some other constant-loading construct).

I think I added that check during my testing before I'd worked out all the constant pool index issues.  Now that they are resolved I removed that check and reran my tests and everything looks fine.  Thanks for catching it.

> 
>>> 
>>> 
>>> The rest of it looks fine.
>> 
>> Thanks.
>> 
>>> 
>>> Some of the new Java code it resembles the corresponding C++ code, in that it seems like code that should be distrusted until it is fully exercised by tests.
>> 
>> What are you saying?
> 
> I'm saying that it's fine, but since I did not mentally prove the change correct (which is possible sometimes), I'm relying on the testing to catch errors.

I see.  I really only changes places that were shown to be broken by testing so I think it's all been tested.  That's part of the reason that I wanted it to look as close as possible to the C++ code so that we can assume correctness by equivalence.

Thanks for the review.

tom

> 
> -- John