Review Request: zero/shark doesn't build after b147-fcs

[Christian Thalinger]

On Jul 28, 2011, at 1:25 PM, Chris Phillips wrote:

> Hi Christian,
> 
> Hmm missed this yesterday,
> The webrev is updated...
> 
> http://lgonqn.org/temp/ChrisPhi/webrev-methodHandles_zero.hpp-missing++

Thanks.  Here is the combined webrev:

http://cr.openjdk.java.net/~twisti/7071823/

I removed the #ifdef notdef'd code from sharedRuntime_zero.cpp because you really don't need it anymore.

I suppose chphilli at redhat.com is your RedHat email address and you're submitting this as a RedHat employee (because of the OCA)?

-- Christian

> 
> 
> Chris
> 
> On 27/07/11 02:31 PM, Christian Thalinger wrote:
>> On Jul 15, 2011, at 4:51 PM, Gary Benson wrote:
>> 
>>> Chris Phillips wrote:
>>>> http://lgonqn.org/temp/ChrisPhi/webrev-sharkContext.hpp-typo-in-assert/
>>> Nice catch :)
>>> 
>>>> http://lgonqn.org/temp/ChrisPhi/webrev-methodHandles_zero.hpp-missing/
>>> You could probably make adapter_code_size be 0, or something small
>>> 1ike 1*k.  Nothing will presumably be generated into these buffers
>>> after all?
>> Chris, can you update the webrev so I can be sure the change works?
>> 
>> -- Christian
>> 
>>> Cheers,
>>> Gary
>>> 
>>> -- 
>>> http://gbenson.net/
>> 
>> 
>