review request (URGENT): 7052202: JSR 292: Crash in sun.invoke.util.ValueConversions.fillArray

[Tom Rodriguez]

Looks good.

tom

On Jun 13, 2011, at 9:22 PM, John Rose wrote:

> These are the JDK-side fixes for several crashes in method handle adapters.
>  http://cr.openjdk.java.net/~jrose/7052202/webrev.jdk.00/
> 
> Summary of changes:
> - correct parameters of some rotate (OP_ROT_ARGS) permutation adapters
> - communicate the rotation convention with the JVM via OP_ROT_ARGS_DOWN_LIMIT_BIAS
> - adjust code in MethodHandleImpl for GWT transformations
> - fix typo in SwitchPoint javadoc
> - fix non-compliant logic in MethodHandleProxies
> - fix invalid private classes in MethodHandlesTest
> 
> 7052202: JSR 292: Crash in sun.invoke.util.ValueConversions.fillArray
> Summary: Fix corner cases involving MethodHandles.permuteArguments with long or double argument lists.
> 
> This bug also has a set of JVM-side fixes, which will also be posted for review.  A preview may be found in the mlvm patch repository:
>  http://hg.openjdk.java.net/mlvm/mlvm/hotspot/file/tip/meth-rot-7052202.patch
> 
> Both change sets are required to fix the bug.  Either change set is safe to apply by itself, and will cause no regression.
> 
> Thanks,
> -- John
> 
>