review request (URGENT): 7052202: JSR 292: Crash in sun.invoke.util.ValueConversions.fillArray

[Christian Thalinger]

On Jun 15, 2011, at 3:18 AM, John Rose wrote:
> I have reviews from Christian and Tom; thanks.
> 
> For more accurate tracking, I have split out some of the changes into a different bug, 7054590:
>   http://cr.openjdk.java.net/~jrose/7054590/webrev.00
> 
> The updated webrev for the remaining changes is here:
>   http://cr.openjdk.java.net/~jrose/7052202/webrev.jdk.01
> 
> Please give it a quick re-review.

Still looks good.  -- Christian

> 
> Besides the split, I also simplified the adjustment in MethodHandleImpl.java to the GWT transformations, as follows:
> 
>          static boolean preferRicochetFrame(MethodType type) {
> -            return (type.parameterCount() >= INVOKES.length || type.hasPrimitives());
> +            return true;  // always use RF if available
>          }
> 
> This particular simplification has been "soaking" in the mlvm-dev builds since 6/03.
> 
> -- John
> 
> On Jun 13, 2011, at 9:22 PM, John Rose wrote:
> 
>> These are the JDK-side fixes for several crashes in method handle adapters.
>>  http://cr.openjdk.java.net/~jrose/7052202/webrev.jdk.00/
>> 
>> Summary of changes:
>> - correct parameters of some rotate (OP_ROT_ARGS) permutation adapters
>> - communicate the rotation convention with the JVM via OP_ROT_ARGS_DOWN_LIMIT_BIAS
>> - adjust code in MethodHandleImpl for GWT transformations
>> - fix typo in SwitchPoint javadoc
>> - fix non-compliant logic in MethodHandleProxies
>> - fix invalid private classes in MethodHandlesTest
>> 
>> 7052202: JSR 292: Crash in sun.invoke.util.ValueConversions.fillArray
>> Summary: Fix corner cases involving MethodHandles.permuteArguments with long or double argument lists.
>> 
>> This bug also has a set of JVM-side fixes, which will also be posted for review.  A preview may be found in the mlvm patch repository:
>>  http://hg.openjdk.java.net/mlvm/mlvm/hotspot/file/tip/meth-rot-7052202.patch
>> 
>> Both change sets are required to fix the bug.  Either change set is safe to apply by itself, and will cause no regression.
>> 
>> Thanks,
>> -- John


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20110615/42f01315/attachment.html