review(M): 7057120: Tiered: Allow C1 to inline methods with loops

[Tom Rodriguez]

Looks good.

tom

On Jun 22, 2011, at 5:34 PM, Igor Veresov wrote:

> Thanks, Vladimir!
> 
> igor
> 
> On 6/22/11 5:24 PM, Vladimir Kozlov wrote:
>> Good.
>> 
>> Vladimir
>> 
>> Igor Veresov wrote:
>>> On 6/22/11 3:08 PM, Vladimir Kozlov wrote:
>>>> Igor Veresov wrote:
>>>>> Thanks for the review, Vladimir! Webrev updated. Please find the
>>>>> replies inline.
>>>>> 
>>>>> On 6/22/11 9:51 AM, Vladimir Kozlov wrote:
>>>>>> Can you explain why in counter_overflow_helper() (c1_Runtime1.cpp) you
>>>>>> expect the caller (enclosing_method) to be nmethod?
>>>>> 
>>>>> It's not the caller. The enclosing_method is the actual method to
>>>>> which the nmethod belongs. In other words: enclosing_method is a
>>>>> method who's frame is current on stack and "method" is possibly the
>>>>> inlinee inside the enclosing method that generated the event.
>>>> 
>>>> It would be better to say this in the comment for
>>>> counter_overflow_helper() method since the current comment does not help
>>>> at all. I don't see
>>>> anything related to safepoint.
>>> 
>>> Done, webrev updated.
>>> 
>>> igor
>