review for 7061101: adlc should complain about mixing block and expression forms of ins_encode
Vladimir Kozlov
vladimir.kozlov at oracle.com
Thu Jun 30 13:48:09 PDT 2011
Good.
Thanks,
Vladimir
Tom Rodriguez wrote:
> How about:
>
> + // Check for duplicate ins_encode sections after parsing the block
> + // so that parsing can continue and find any other errors.
>
> tom
>
> On Jun 30, 2011, at 11:27 AM, Vladimir Kozlov wrote:
>
>> Yes, could it says something like this?:
>>
>> // We do this check after block parsing so that we can also catch problems in the block
>>
>> Vladimir
>>
>> Tom Rodriguez wrote:
>>> On Jun 30, 2011, at 11:20 AM, Vladimir Kozlov wrote:
>>>> Looks good but I do not understand your comment. Did you mean the check is done after parsing a ins_encode block instead of before it?
>>> Yes. Should I change it somehow?
>>> tom
>>>> Thanks,
>>>> Vladimir
>>>>
>>>> Tom Rodriguez wrote:
>>>>> http://cr.openjdk.java.net/~never/7061101
>>>>> 12 lines changed: 12 ins; 0 del; 0 mod; 5050 unchg
>>>>> 7061101: adlc should complain about mixing block and expression forms of ins_encode
>>>>> Reviewed-by:
>>>>> Only one ins_encode should be specified. Tested with bad ad file.
>
More information about the hotspot-compiler-dev
mailing list