Request for review (XL): 7012648: move JSR 292 to package java.lang.invoke and adjust names

[Christian Thalinger]

On Mar 4, 2011, at 1:48 AM, Vladimir Kozlov wrote:
> systemDictionary.hpp: why switching back to sun.dyn?:
> 
> -  template(MethodHandleImpl_klass,       java_dyn_MethodHandleImpl, Pre_JSR292) /* AllowTransitionalJSR292 ONLY */ \
> +  template(MethodHandleImpl_klass,       sun_dyn_MethodHandleImpl, Opt) /* AllowTransitionalJSR292 ONLY */ \

That's because MethodHandleImpl goes away with 7012648 and we just use sun_dyn_MethodHandleImpl.  It doesn't matter what name it has, both packages (sun.dyn and java.dyn) are searched anyway.

> 
> 
> methodHandleWalk.cpp: comment says "java.dyn" but should it be "java.lang.invoke"? :
> 
> +   if (m == NULL)
> +     // sun.dyn.MethodHandleImpl not found, look for java.dyn.MethodHandleNatives:
> +     m = vmIntrinsics::method_for(vmIntrinsics::_checkSpreadArgument_TRANS2);

No, that's correct.  checkSpreadArgument will be moved to java.dyn.MethodHandleNatives with 6839872 and finally to java.lang.invoke.MethodHandleNatives with 7012648.

I know it's confusing but all this will go away, eventually.

-- Christian

> 
> Vladimir
> 
> Christian Thalinger wrote:
>> http://cr.openjdk.java.net/~twisti/7012648/webrev.01/
>> 7012648: move JSR 292 to package java.lang.invoke and adjust names
>> Summary: package and class renaming only; delete unused methods and classes
>> Reviewed-by:
>> At the request of the JDK7 Architect, the JSR 292 EG has agreed moving
>> the API from the package java.dyn to the package java.lang.invoke.
>> This is the JVM part of 7012648.
>> The support for the old namespace (AllowTransitionalJSR292) will be
>> removed as soon as the related JDK changes appear in the
>> repositories.