Request for review (XS): 7027232: JSR 292: wrong numeric value returned by MH on solaris-sparc

Paul Hohensee paul.hohensee at oracle.com
Tue Mar 15 10:57:20 PDT 2011


Would love to drop V8 support in C1, but as long as we ship the current 
version
of Hotspot in jdk6, we can't do it.  We're trying (and failing at the 
moment) to
decommit from that, but imo we're going to be stuck with delivering the 
current
jvm into the jdk6 train for a year at least.

Paul

On 3/15/11 1:22 PM, Vladimir Kozlov wrote:
> Christian,
>
> We don't support little-endian SPARC, why add a code which will never 
> be executed?
>
> On side note (RFE): we should officially drop v8 support (C2 does not 
> support already, only C1). There are already several places where we 
> use stx/ldx without check that it is v9 (yes, we still have an assert 
> which is fine). Also std/ldd is emulated on modern SPARC and so is 
> very slow.
>
> Thanks,
> Vladimir
>
> Christian Thalinger wrote:
>> http://cr.openjdk.java.net/~twisti/7027232/
>>
>> 7027232: JSR 292: wrong numeric value returned by MH on solaris-sparc
>> Reviewed-by:
>>
>> After 7018378 one of the tests of java/dyn/MethodHandlesTest fails on
>> 32-bit SPARC.  st_long uses STD on 32-bit SPARC and the LSW and MSW
>> bits are not moved to the proper registers resulting in a wrong
>> result.
>>
>> The fix is to use the correct registers for 32-bit big-endian and
>> little-endian (just in case) SPARC.
>>
>> src/cpu/sparc/vm/methodHandles_sparc.cpp
>>


More information about the hotspot-compiler-dev mailing list