review (XS) for 6478991: C1 NullCheckEliminator yields incorrect exceptions

Tom Rodriguez tom.rodriguez at oracle.com
Mon Mar 28 13:33:55 PDT 2011


Oops.  I'll fix that in another putback.  It's also full of ^M which I will fix as well.  Thanks.

tom

On Mar 28, 2011, at 1:41 AM, Christian Thalinger wrote:

> On Mar 25, 2011, at 7:37 PM, Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6478991
>> 
>> 6478991: C1 NullCheckEliminator yields incorrect exceptions
>> Reviewed-by:
>> 
>> checkcast can trap so don't allow explicit null checks to be folded into
>> instructions that follow it.  Tested with new test case.
> 
> The testcase misses the -Xcomp flag.
> 
> -- Christian



More information about the hotspot-compiler-dev mailing list