review(XXS): 7026307: DEBUG MESSAGE: broken null klass on amd64

[Igor Veresov]

Thanks Tom and Vladimir!

igor

On 3/29/11 10:20 PM, Vladimir Kozlov wrote:
> Good.
>
> Vladimir
>
> On 3/29/11 9:49 PM, Igor Veresov wrote:
>> I made a copy-paste error while refactoring for 7020521, in
>> stubGenerator_x86_64.cpp:
>> address generate_generic_copy(const char *name,
>> address byte_copy_entry, address short_copy_entry,
>> address int_copy_entry, address long_copy_entry,
>> address oop_copy_entry, address checkcast_copy_entry)
>>
>> The order of arguments is wrong, entry_oop_arraycopy and
>> entry_jlong_arraycopy should be swapped like on other
>> architectures. With compressed oops this would cause stomping, among
>> other things, which was caught in nighlies.
>>
>> Webrev: http://cr.openjdk.java.net/~iveresov/7026307/webrev.00/
>>
>> Testing: Failing nightly test.
>>
>>
>> Thanks,
>> igor