Review Request: Zero and Shark fixes

[Gary Benson]

Dr Andrew John Hughes wrote:
> On 30 March 2011 12:51, Gary Benson <gbenson at redhat.com> wrote:
> > Christian Thalinger wrote:
> > > On Mar 30, 2011, at 12:52 PM, Gary Benson wrote:
> > > > This webrev contains a bunch of fixes for Zero and Shark:
> > > >
> > > >  http://cr.openjdk.java.net/~gbenson/zero-shark-fixes-04/
> > > >
> > > > Firstly, changes to tiered compilation required fixes to allow
> > > > Shark to build.  Secondly, my fix for 7030207 uncovered a bug
> > > > in the C++ interpreter where finalizers were not being
> > > > registered.  I can split the webrev into two if you'd like.
> > >
> > > hotspot/src/share/vm/compiler/compileBroker.cpp:
> > >
> > > -  if (compiler(comp_level)->is_c2()) {
> > > +  if (compiler(comp_level)->is_c2() || compiler(comp_level)->is_c2()) {
> > >
> > > That seems to be a typo or leftover.
> >
> > Ah, well spotted, the second should be is_shark.
> >
> > Would you like me to remake the webrev?
> 
> Yes, please also split this up so it's easier to backport.

Whether I split it is up to twisti.  I don't want to jam their
testing thing all afternoon with six tiny patches...

Cheers,
Gary

-- 
http://gbenson.net/