Review Request: Zero and Shark fixes
Christian Thalinger
christian.thalinger at oracle.com
Wed Mar 30 06:29:15 PDT 2011
On Mar 30, 2011, at 2:51 PM, Gary Benson wrote:
> Christian Thalinger wrote:
>> On Mar 30, 2011, at 1:51 PM, Gary Benson wrote:
>>> Christian Thalinger wrote:
>>>> On Mar 30, 2011, at 12:52 PM, Gary Benson wrote:
>>>>> This webrev contains a bunch of fixes for Zero and Shark:
>>>>>
>>>>> http://cr.openjdk.java.net/~gbenson/zero-shark-fixes-04/
>>>>>
>>>>> Firstly, changes to tiered compilation required fixes to allow
>>>>> Shark to build. Secondly, my fix for 7030207 uncovered a bug
>>>>> in the C++ interpreter where finalizers were not being
>>>>> registered. I can split the webrev into two if you'd like.
>>>>
>>>> hotspot/src/share/vm/compiler/compileBroker.cpp:
>>>>
>>>> - if (compiler(comp_level)->is_c2()) {
>>>> + if (compiler(comp_level)->is_c2() || compiler(comp_level)->is_c2()) {
>>>>
>>>> That seems to be a typo or leftover.
>>>
>>> Ah, well spotted, the second should be is_shark.
>>>
>>> Would you like me to remake the webrev?
>>
>> No, it's okay. -- Christian
>
> Awesome, thanks.
7032458: Zero and Shark fixes
-- Christian
More information about the hotspot-compiler-dev
mailing list