Review Request: Zero and Shark fixes

[Dr Andrew John Hughes]

On 30 March 2011 15:21, Christian Thalinger
<christian.thalinger at oracle.com> wrote:

> Nothing's pushed yet so we still can talk about and change it.  What exactly do you want to split?
>
> -- Christian

Thanks.  From the webrev, there seem to be at least three changes:

1. Makefile changes which make sure the Shark files are once again
compiled (and which I believe would need to be reviewed by Kelly
anyway)
2. The trivial #ifndef addition which fixes a regression introduced by
the recent HotSpot security fix.
3. The fix for the bug Gary mentioned which appears to mean API
changes (I don't completely understand this bit).

The first two have been tested in IcedTea6 and correspond to
regressions introduced by identifiable changesets.
I'm not sure of the impact of the third.

The hs20 stable branch needs 1.  but does not need 2. at present as it
doesn't have the security fix to my knowledge.
I'd prefer they were added separately, but I could live with 1 & 2
being combined, provided the security fix went into OpenJDK6 first.
The build changes do need to be reviewed by Kelly:
http://mail.openjdk.java.net/pipermail/build-dev/2011-February/004034.html
so it would make sense to have 1 separate in that respect.

I would definitely like to see 3 separated as it's new and (AFAIK)
largely untested.

Thanks,
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37