Request for review (S): 7032388: guarantee(VM_Version::supports_cmov()) failed: illegal instruction on i586 after 6919934

[Tom Rodriguez]

Looks good.

tom

On Mar 30, 2011, at 5:46 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/7032388/
> 
> 7032388: guarantee(VM_Version::supports_cmov()) failed: illegal instruction on i586 after 6919934
> Summary: 6919934 added some unguarded cmov instructions which hit a guarantee on older hardware.
> Reviewed-by:
> 
> 6919934 added some unguarded cmov instructions which hit a guarantee
> on older hardware (pre-i686).
> 
> The fix is to either guard the added cmov instructions with a
> supports_cmov() or let the cmov instruction decide itself if the
> hardware supports cmov and if not use a branch-mov idiom.  I chose the
> latter.
> 
> src/cpu/x86/vm/assembler_x86.cpp
> src/cpu/x86/vm/assembler_x86.hpp
> src/cpu/x86/vm/c1_LIRAssembler_x86.cpp
> src/cpu/x86/vm/c1_Runtime1_x86.cpp
> src/cpu/x86/vm/templateTable_x86_32.cpp
>