Request for reviews (M): 7032314: Allow to generate CallLeafNoFPNode in IdealKit
Vladimir Kozlov
vladimir.kozlov at oracle.com
Wed Mar 30 13:45:05 PDT 2011
Thank you, Tom
I am fine to have a separate final sync method since I am touching all places
where it is used anyway. How about this?
void GraphKit::sync_kit(IdealKit& ideal) {
set_all_memory(__ merged_memory());
set_i_o(__ i_o());
set_control(__ ctrl());
}
void GraphKit::final_sync(IdealKit& ideal) {
// Final sync IdealKit and graphKit.
__ drain_delay_transform();
sync_kit(ideal);
}
Vladimir
Tom Rodriguez wrote:
> Thanks for bringing this over. The only thing I don't like is the extra arg to sync_kit though I don't have any good suggestions for making it nicer. Maybe the existing sync_kit should be sync_and_drain with sync_kit skipping the drain? Anyway, maybe the flag is fine. However you want to handle it is ok with me.
>
> tom
>
> On Mar 30, 2011, at 11:34 AM, Vladimir Kozlov wrote:
>
>> http://cr.openjdk.java.net/~kvn/7032314/webrev
>>
>> Fixed 7032314: Allow to generate CallLeafNoFPNode in IdealKit
>>
>> Added CallLeafNoFPNode generation to IdealKit. Added i_o synchronization.
>> Consolidated synchronization code for IdealKit and graphKit.
>>
>
More information about the hotspot-compiler-dev
mailing list