review(XXS) 6564610: assert(UseCompiler || CompileTheWorld, "UseCompiler should be set by now.")

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Mar 30 15:02:38 PDT 2011


Looks good.

Vladimir

Igor Veresov wrote:
> The assert mentioned in the bug synopsis is sometimes observed when the 
> code cache gets full.  What happens is a race between a check for 
> UseCompiler in NonTieredCompPolicy::event() and checks in asserts in 
> method_invocation_event() and method_back_branch_event(). The value of 
> UseCompiler can change in-between. It is wrong to assert that 
> UseCompiler is set or not because it can change asynchronously at any 
> point. The solution is to remove the asserts.
> 
> Webrev: http://cr.openjdk.java.net/~iveresov/6564610/webrev.00/
> 
> 
> Thanks,
> igor


More information about the hotspot-compiler-dev mailing list