Review Request: Zero and Shark fixes

Gary Benson gbenson at redhat.com
Thu Mar 31 02:26:24 PDT 2011


Dr Andrew John Hughes wrote:
> On 30 March 2011 16:16, Gary Benson <gbenson at redhat.com> wrote:
> > Christian Thalinger wrote:
> > > On Mar 30, 2011, at 4:55 PM, Gary Benson wrote:
> > > > Christian Thalinger wrote:
> > > > > Andrew, can you take care of 1. and send it to build-dev?
> > > > > I take the rest of the patch (2. and 3.) and push it as
> > > > > the one CR I created.  I don't think it makes much sense
> > > > > to have an extra CR for 2.
> > > >
> > > > Would you like me to make new webrevs?
> > >
> > > Yes, that would be good for the record and to put URL into
> > > the CR.
> >
> > http://cr.openjdk.java.net/~gbenson/zero-shark-fixes-04-1/
> >  is the build fixes, for Andrew.
> 
> Thanks.  http://mail.openjdk.java.net/pipermail/build-dev/2011-March/004369.html

Thanks.

> Assuming you came up with this change and didn't see the one in
> IcedTea, it's interesting that they are virtually identical.

I didn't see it, but it's the logical way to do it given how it's
done for the other cases.

What's with the launcher.make changes in that patch?  I've not
seen that before.

Cheers,
Gary

-- 
http://gbenson.net/


More information about the hotspot-compiler-dev mailing list