review for 7043040: JSR292: JRuby bench/shootout/binarytrees.ruby-2.ruby SEGV: constantPoolKlass::oop_follow_contents

[Tom Rodriguez]

Thanks Vladimir and Ramki.

tom

On May 10, 2011, at 2:38 PM, Y. S. Ramakrishna wrote:

> looks good.
> 
> -- ramki
> 
> On 05/10/11 13:21, Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/7043040
>> 7043040: JSR292: JRuby bench/shootout/binarytrees.ruby-2.ruby SEGV: constantPoolKlass::oop_follow_contents
>> Reviewed-by:
>> The logic in oop_push_constants was skipping JVM_CONSTANT_Object
>> entries which would cause corruption in later GCs.  The fix is to use
>> is_pointer_entry to identify roots like all the other visitor.  The
>> verify_on method was also too weak so it missed the problem when run
>> with the verify GC flags.  Tested with failing test from report.