review for 7046732: JSR 292 assert(result == cpce->f1()) failed: expected result for assembly code

[John Rose]

Good.  -- John

On May 24, 2011, at 1:46 PM, Tom Rodriguez wrote:

> http://cr.openjdk.java.net/~never/7046732
> 1 line changed: 0 ins; 0 del; 1 mod; 1262 unchg
> 
> 7046732: JSR 292 assert(result == cpce->f1()) failed: expected result for assembly code
> Reviewed-by:
> 
> The assert doesn't hold when the resolve_constant throws an exception.
> It should be using CHECK instead of THREAD so that it returns
> immediately.  Tested with failing test case.
>