review for 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly

John Coomes John.Coomes at oracle.com
Wed May 25 12:45:11 PDT 2011


Tom Rodriguez (tom.rodriguez at oracle.com) wrote:
> http://cr.openjdk.java.net/~never/7047961
> 316 lines changed: 213 ins; 27 del; 76 mod; 5061 unchg
> 
> 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly
> ...

Not a real review, just a nit-pick:  '#ifdef DEBUG' should be '#ifdef
ASSERT' since DEBUG is not defined consistently in our builds (e.g.,
not in fastdebug builds).

-John


More information about the hotspot-compiler-dev mailing list