review for 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly

[John Coomes]

Tom Rodriguez (tom.rodriguez at oracle.com) wrote:
> 
> On May 25, 2011, at 12:45 PM, John Coomes wrote:
> 
> > Tom Rodriguez (tom.rodriguez at oracle.com) wrote:
> >> http://cr.openjdk.java.net/~never/7047961
> >> 316 lines changed: 213 ins; 27 del; 76 mod; 5061 unchg
> >> 
> >> 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly
> >> ...
> > 
> > Not a real review, just a nit-pick:  '#ifdef DEBUG' should be '#ifdef
> > ASSERT' since DEBUG is not defined consistently in our builds (e.g.,
> > not in fastdebug builds).
> 
> Thanks for catching that.  A little grepping suggests that there are
> quite a places that are still using DEBUG.  DEBUG_ONLY vs ifdef
> ASSERT has always bugged too.  I've corrected my code.

FWIW, I filed bugs a while back to track the DEBUG vs. ASSERT problems
(6860048, 6990414).  I expect to get rid of the remaining #ifdef DEBUG
lines after jdk7.

-John