review for 7108242: jinfo -permstat shouldn't report interned strings as part of perm

[Tom Rodriguez]

Thanks.

tom

On Nov 4, 2011, at 1:59 PM, Vladimir Kozlov wrote:

> Thank you, Tom
> 
> this looks good
> 
> Vladimir
> 
> Tom Rodriguez wrote:
>> On Nov 4, 2011, at 10:29 AM, Tom Rodriguez wrote:
>>> That seems like a reasonable place to move it.  I'll do that and send out a new webrev.
>> I've moved it into HeapSummary.java so it will now be reported as part of jmap -heap.
>> tom
>> Parallel GC with 8 thread(s)
>> Heap Configuration:
>>   MinHeapFreeRatio = 40
>>   MaxHeapFreeRatio = 70
>>   MaxHeapSize      = 1073741824 (1024.0MB)
>>   NewSize          = 1048576 (1.0MB)
>>   MaxNewSize       = 4294901760 (4095.9375MB)
>>   OldSize          = 4194304 (4.0MB)
>>   NewRatio         = 2
>>   SurvivorRatio    = 8
>>   PermSize         = 16777216 (16.0MB)
>>   MaxPermSize      = 67108864 (64.0MB)
>> Heap Usage:
>> PS Young Generation
>> Eden Space:
>>   capacity = 17301504 (16.5MB)
>>   used     = 346136 (0.33010101318359375MB)
>>   free     = 16955368 (16.169898986816406MB)
>>   2.0006122011126894% used
>> From Space:
>>   capacity = 2883584 (2.75MB)
>>   used     = 0 (0.0MB)
>>   free     = 2883584 (2.75MB)
>>   0.0% used
>> To Space:
>>   capacity = 2883584 (2.75MB)
>>   used     = 0 (0.0MB)
>>   free     = 2883584 (2.75MB)
>>   0.0% used
>> PS Old Generation
>>   capacity = 44040192 (42.0MB)
>>   used     = 0 (0.0MB)
>>   free     = 44040192 (42.0MB)
>>   0.0% used
>> PS Perm Generation
>>   capacity = 16777216 (16.0MB)
>>   used     = 1952152 (1.8617172241210938MB)
>>   free     = 14825064 (14.138282775878906MB)
>>   11.635732650756836% used
>> 613 interned Strings occupying 37008 bytes.
>>> tom
>>> 
>>> On Nov 3, 2011, at 5:11 PM, Vladimir Kozlov wrote:
>>> 
>>>> Can you move it to HeapSummary.java?
>>>> 
>>>> Vladimir
>>>> 
>>>> Tom Rodriguez wrote:
>>>>> http://cr.openjdk.java.net/~never/7108242
>>>>> 38 lines changed: 0 ins; 38 del; 0 mod; 279 unchg
>>>>> 7108242: jinfo -permstat shouldn't report interned strings as part of perm
>>>>> Reviewed-by:
>>>>> jinfo -permstat still reports interned strings as part of the perm gen
>>>>> which is no longer true.  It should be dropped.