Request for review (XS): 7108383: JSR 292: JRuby bench_define_method_methods.rb: assert(slow_jvms != NULL) failed: miss path must not

[Tom Rodriguez]

looks ok.

tom

On Nov 9, 2011, at 5:31 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/7108383/
> 
> 7108383: JSR 292: JRuby bench_define_method_methods.rb: assert(slow_jvms != NULL) failed: miss path must not
> Reviewed-by:
> 
> The problem is that the code in
> PredictedDynamicCallGenerator::generate assumes that the generation of
> the slow path always succeeds.  This might not be the case when we hit
> the node limit while generating the slow path.
> 
> The suggested fix is to remove the assert and return on failed slow
> path generations.
> 
> I also applied the fix to PredictedCallGenerator::generate because I
> think it can also happen there.
> 
> src/share/vm/opto/callGenerator.cpp
>