review(S): 7112085: assert(fr.interpreter_frame_expression_stack_size()==0) failed: only handle empty stacks

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Nov 16 12:46:18 PST 2011


Looks good.

Did it pass all compiler regression tests with -XX:+TieredCompilation 
-XX:+DeoptimizeALot?

Thanks,
Vladimir

Igor Veresov wrote:
> The runtime call to the policy from the inlinee invocation had an 
> incorrect jvm state. As a result the bytecode preceding the invoke of 
> the inlinee was executed twice in case we deoptimized. Since it's 
> currently not quite easy to set the reexecute flag in C1, I moved the 
> notification call into the preamble of the inlinee so that I could use 
> InvocationEntryBci in the state specification, which would deopt correctly.
> 
> Also made some minor changes to printing of tiered events.
> 
> Webrev:  http://cr.openjdk.java.net/~iveresov/7112085/webrev.00/
> 
> Thanks!
> igor
> 


More information about the hotspot-compiler-dev mailing list