review(S): 7097679: Tiered: events with bad bci to Gotos reduced from Ifs

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Oct 4 08:49:54 PDT 2011


Looks good.

Vladimir

On 10/3/11 10:48 PM, Igor Veresov wrote:
> In case with back branches Runtime1::counter_overflow() routine expects to receive a bci of either a Goto of If
> instruction that generated
> the event. When emitting the counter overflow stub for the Goto we take the bci from the jvm state. However it is not
> correct for the Gotos
> that were produced as a result of the reduction of Ifs because in this case the state will have a bci that would
> possibly point to a Cmp preceding the If instead.
>
> The solution is to always store a proper bci for Goto and use it instead of the one in the jvm state.
>
> Webrev: http://cr.openjdk.java.net/~iveresov/7097679/webrev.00
>
> Thanks!
> igor


More information about the hotspot-compiler-dev mailing list