review for 7105305: assert check_method_context proper context

[Tom Rodriguez]

Thanks!

tom

On Oct 26, 2011, at 2:57 PM, Vladimir Kozlov wrote:

> Looks good. I think it was typo in is_concrete_method().
> 
> Vladimir
> 
> Tom Rodriguez wrote:
>> This may causes some other CTW issues but I will file separate bugs for those, unless they have a simple fix I can include here.
>> http://cr.openjdk.java.net/~never/7105305
>> 6 lines changed: 2 ins; 0 del; 4 mod; 2198 unchg
>> 7105305: assert check_method_context proper context
>> Reviewed-by:
>> preload_and_initialize_all_classes intends to initialize all
>> instanceKlasses but is using the wrong check.  Fixing that exposes a
>> bug in the dependencies where the is_concrete_method isn't checking
>> for is_static.  The fix is to make it consistent with the ciMethod
>> variant.  Tested with full CTW.