Request for reviews (XS): 7104561: UseRDPCForConstantTableBase doesn't work after shorten branches changes

Christian Thalinger christian.thalinger at oracle.com
Fri Oct 28 02:08:00 PDT 2011


On Oct 27, 2011, at 8:55 PM, Christian Thalinger wrote:

> 
> On Oct 27, 2011, at 8:05 PM, Tom Rodriguez wrote:
> 
>> Looks good.  Do you want to turn it on too?
> 
> Yeah, good idea.  -- Chris

That would be this additional change then:

http://cr.openjdk.java.net/~twisti/7104561/src/cpu/sparc/vm/vm_version_sparc.cpp.udiff.html

-- Chris

> 
>> 
>> tom
>> 
>> On Oct 27, 2011, at 10:55 AM, Christian Thalinger wrote:
>> 
>>> http://cr.openjdk.java.net/~twisti/7104561/
>>> 
>>> 7104561: UseRDPCForConstantTableBase doesn't work after shorten branches changes
>>> Reviewed-by:
>>> 
>>> Before 7063629 Compile::shorten_branches was not used on SPARC.  Now
>>> all architectures call that method and we need to take care of that
>>> fact in MachConstantNode::constant_offset when called from
>>> Compile::scratch_emit_size.
>> 
> 



More information about the hotspot-compiler-dev mailing list