Request for reviews (M): 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods

[Christian Thalinger]

Thank you, Tom.  -- Chris

On Oct 31, 2011, at 8:03 PM, Tom Rodriguez wrote:

> The test looks fine.
> 
> tom
> 
> On Oct 31, 2011, at 11:27 AM, Christian Thalinger wrote:
> 
>> Could someone have a quick look just to be sure that the test is okay?
>> 
>> -- Chris
>> 
>> On Oct 27, 2011, at 1:17 PM, Christian Thalinger wrote:
>> 
>>> I'm about to push the JDK changes to hsx/hotspot-main/jdk.  To have some testing coverage I added a test case and I'd like to have at least one review of that:
>>> 
>>> http://cr.openjdk.java.net/~twisti/7085860-jdk/
>>> 
>>> -- Chris
>>> 
>>> On Sep 8, 2011, at 9:39 PM, John Rose wrote:
>>> 
>>>> On Sep 8, 2011, at 9:03 AM, Tom Rodriguez wrote:
>>>> 
>>>>> That looks good.  One thing that occurred to me is that reading of the target field within the JVM must be done as if it were volatile, since we don't actually know what type of call site we're reading from.  You could put a check in CallSite::target but I think you just always read it as volatile.  I suspect the invokedynamic call site assembly also needs to do any required barriers.
>>>> 
>>>> Nice catch.
>>>> 
>>>> Maybe change "target" to "target_non_volatile", to emphasize the different uses of the target field.
>>>> 
>>>> -- John
>>> 
>> 
>