Request for reviews (S): 7071709: JSR 292: switchpoint invalidation should be pushed not pulled

[Christian Thalinger]

On Aug 31, 2011, at 11:34 PM, John Rose wrote:

> On Aug 31, 2011, at 3:42 AM, Christian Thalinger wrote:
> 
>> This patch now only contains the SwitchPoint optimization and will be pushed as the last of my fixes (as stated in an earlier email):
>> 
>> http://cr.openjdk.java.net/~twisti/7071709/
>> 
>> Tom, John, can you review this again?
> 
> 
> It is good, but I have a question.  What happens when this line produces a null value for the target (because of -Xcomp etc.):
>   ciMethodHandle* target = call_site->get_target();
> 
> Shouldn't there be a guard for that edge case, in case Murphy's Law kicks in?

Yes, there should be one.  I added a null check.

-- Christian

> 
> -- John

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20110902/4622f3f4/attachment.html