review request (S): 7087453: PhaseChaitin::yank_if_dead() should handle MachTemp inputs

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Sep 6 11:19:32 PDT 2011


So why this code can't handle more then one non TEMP inputs? Is it because the 
'old' node should have only one non TEMP input (which I doubt) or yank_if_dead() 
code is not correct - can't process more inputs? If it is later we should fix 
the code.

Thanks,
Vladimir

Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/7087453/webrev.00/
> 
> When PhaseChaitin::yank_if_dead() hits a node with MachTemp inputs it 
> crashes the VM with assertion:
> assert(old->req() <= 2, "can't handle more inputs");
> It should be able to handle MachTemps as a special case by yanking them 
> as well.
> 
> Roland.


More information about the hotspot-compiler-dev mailing list