Request for reviews (M): 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods

[Christian Thalinger]

On Sep 7, 2011, at 9:09 PM, John Rose wrote:

> On Sep 7, 2011, at 6:37 AM, Christian Thalinger wrote:
> 
>> http://cr.openjdk.java.net/~twisti/7085860/
>> 
>> 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods
>> Reviewed-by:
> 
> Yes, looks good.  (I agree with Tom that "volatile_put" is harder to read than "put_volatile".  In the latter formulation, "volatile" modifies "put" more clearly.)
> 
> Will there be a separate bug for throttling megamutable sites, after Tom's field injection stuff goes in?

Yes.  I filed:

7087838: JSR 292: add throttling logic for optimistic call site optimizations

Thanks for the reviews.

-- Christian

> 
> -- John

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20110907/d5d26ed6/attachment.html