review request (M): 7090968 Allow adlc register class to depend on runtime conditions

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Sep 16 12:19:32 PDT 2011


Roland,

Both parts look fine. If you not done it already I would suggest to do full 
round of testing on all platforms and bitness with usual set: CTW, nsk, jtreg.

Vladimir

Tom Rodriguez wrote:
> Looks good to me.
> 
> tom
> 
> On Sep 15, 2011, at 7:21 AM, Roland Westrelin wrote:
> 
>> http://cr.openjdk.java.net/~roland/7090968/webrev.00/
>>
>> This adds the ability to define reg_class'es in the ad file that, rather than being static, depend on runtime conditions. For the current XXX reg_class, the generated XXX_mask const RegMask declarations are renamed _XXX_mask. XXX_mask inline function definitions are introduced that return _XXX_mask. A new form of reg_class definitions such as:
>>
>> reg_class some_reg_class %{
>> 	// some C code
>> %}
>>
>> is introduced. In this case, the body of the generated inline SOME_REG_CLASS_mask function is defined with the C code present between %{ and %} above.
>>
>> Tom suggested I used this opportunity to get rid of inline_cache_reg_mask(), interpreter_method_oop_reg_mask(), interpreter_frame_pointer_reg_mask() that are unused. 
>>
>> Roland.
> 


More information about the hotspot-compiler-dev mailing list