review for 7092278: "jmap -finalizerinfo" throws "sun.jvm.hotspot.utilities.AssertionFailure: invalid cp index 0 137"

[Vladimir Kozlov]

You missed an other unused fields local:

  868   private Field newField(int index) {
  869     TypeArray fields = getFields();

otherwise looks good.

Vladimir

Tom Rodriguez wrote:
> It was pointed out to me that the vmSymbols changes were incomplete.  There aren't currently exercised, so I added a little logic to iterate them when the InstanceKlass is constructed.  This exposed another issue where getAllFieldsCount() wasn't being scaled properly.  It all works now.
> 
> tom
> 
> On Sep 28, 2011, at 9:27 AM, Vladimir Kozlov wrote:
> 
>> Good.
>>
>> Vladimir
>>
>> Tom Rodriguez wrote:
>>> http://cr.openjdk.java.net/~never/7092278
>>> 131 lines changed: 101 ins; 9 del; 21 mod; 5998 unchg
>>> 7092278: "jmap -finalizerinfo" throws "sun.jvm.hotspot.utilities.AssertionFailure: invalid cp index 0 137"
>>> Reviewed-by:
>>> There's was a mismatch between using scaled and unscaled indexes to
>>> refer to fields in the SA because I hadn't completly hidden access to
>>> the fields.  I also added proper support for reading the internal
>>> field names though that's currently not need for these tests.  Tested
>>> with tmtools suite, including the failing test.
>