review for 7161796: PhaseStringOpts::fetch_static_field tries to fetch field from the Klass instead of the mirror

Christian Thalinger christian.thalinger at oracle.com
Tue Apr 17 11:07:10 PDT 2012


Looks good.  -- Chris

On Apr 17, 2012, at 10:50 AM, Tom Rodriguez wrote:

> http://cr.openjdk.java.net/~never/7161796
> 4 lines changed: 1 ins; 0 del; 3 mod; 1448 unchg
> 
> 7161796: PhaseStringOpts::fetch_static_field tries to fetch field from the Klass instead of the mirror
> Reviewed-by:
> 
> When the static fields were moved from the Klass to the Class some
> code in stringopts.cpp was missed.  It's currently bening because the
> only place it's used is for a static final field, so it gets replaced
> with a constant.  Fixed by replaced the Klass with the Class.  I also
> added a short circuit for the constant path.  Tested with specjbb2005
> which exercises this path.
> 



More information about the hotspot-compiler-dev mailing list