Request for reviews (S): 7192167: JSR 292: C1 has old broken code which needs to be removed

[Christian Thalinger]

On Aug 18, 2012, at 3:12 PM, John Rose <john.r.rose at oracle.com> wrote:

> Looks good. What tests now pass and how did you test the change?

There were no failing tests because the force inline hid it.  I did testing with Nashorn and JRuby with -XX:-Inline.

-- Chris

> 
> -- John  (on my iPhone)
> 
> On Aug 17, 2012, at 6:17 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
>> http://cr.openjdk.java.net/~twisti/7192167
>> 
>> 7192167: JSR 292: C1 has old broken code which needs to be removed
>> Reviewed-by:
>> 
>> Some code in C1 is still from the old JSR 292 implementation and is
>> completely wrong.  It works right now because we force all lambda form
>> adapters to inline.  When disabling inlining it fails immediately
>> with SEGVs and friends.
>> 
>> Additionally I removed some unused code in C2.
>> 
>> src/share/vm/c1/c1_GraphBuilder.cpp
>> src/share/vm/c1/c1_Instruction.cpp
>> src/share/vm/c1/c1_LIRAssembler.cpp
>> src/share/vm/c1/c1_LIRGenerator.cpp
>> src/share/vm/opto/callGenerator.cpp
>>