RFR (S): CR 8004318/JEP 171 Fences intrinsics

Doug Lea dl at cs.oswego.edu
Mon Dec 3 16:00:10 PST 2012


On 12/03/12 18:12, Aleksey Shipilev wrote:
> On 12/04/2012 03:10 AM, Christian Thalinger wrote:
>>> Please see the preliminary webrev for changes associated with JEP
>>> 171 aka Fences [1]. The webrev is here:
>>> http://shipilev.net/pub/jdk/hotspot/fences/webrev-1/
>>
>> src/share/vm/opto/library_call.cpp:
>>
>> You should pass the intrinsic_id down to inline_unsafe_fence like we
>> do for inline_fp_conversions.  All these boolean arguments are only
>> confusing.
>
> Fair enough. Thanks for the review! I will wait for more reviews and
> update the webrev.
>

Yes, thanks Christian. The use of ids simplifies this simple set
of patches a little bit more.

-Doug




More information about the hotspot-compiler-dev mailing list