RFR(S): 8003983 Fix of broken logcompilation tool
Vladimir Kozlov
Vladimir.Kozlov at oracle.com
Tue Dec 4 11:05:39 PST 2012
On 12/04/12 08:10, Bharadwaj Yadavalli wrote:
> Not sure if my review counts (I am an "author" buy not a "committer"),
> but the changes look good to me as well.
It is always encouraging for everyone in the group to do reviews and
send comments/questions regardless his status. Unfortunately for
changesets we have to specify official reviewers (you become one after
pushing 32 changesets).
Vladimir
>
> Bharadwaj
>
> On 12/4/2012 6:06 AM, Nils Eliasson wrote:
>> Thanks Vladimir!
>>
>> I think I need a second review. Anyone?
>>
>> //Nils
>>
>> Vladimir Kozlov skrev 2012-11-26 20:30:
>>> Looks good.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 11/26/12 07:04, Nils Eliasson wrote:
>>>> Fixing LogCompilation tool so that I can do my own additions later.
>>>>
>>>> Includes fixes for:
>>>> c1 missing parse tag that is required to surround method tag
>>>> c1 call tag requires count attribute
>>>> c1 phase tag requires nodes (set to zero since there is no nodes
>>>> concept
>>>> in c1)
>>>> Method tag must handle missing bytes, iicount and flags attributes when
>>>> unloading=1 is set
>>>> Wrong description in help for '-n'.
>>>>
>>>> http://cr.openjdk.java.net/~neliasso/8003983/webrev.01/
>>>>
>>>> Tested with running HelloDate on tiered with -Xcomp. Will add this as
>>>> jtreg test separately.
>>>>
>>>> Thanks,
>>>> Nils Eliasson
>>
More information about the hotspot-compiler-dev
mailing list